search

openservicemesh / osm

Open Service Mesh (OSM) is a lightweight, extensible, cloud native service mesh that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
https://openservicemesh.io/
Apache License 2.0
2.58k stars 277 forks source link

fix(): linter running on PR misses errors #5316

Closed jaellio closed 1 year ago

jaellio commented 1 year ago

Description: Replaces only-new-issues with new command line argument

only-new-issues was added in a recent PR to the linter github action. This condition only applies when making a pull request, not on merging/pushing. Therefore, on pull request the linter was run with the additional command line options: --new-from-patch=/tmp/tmp-1758-4jITrYvTb07C/pull.patch --new=false --new-from-rev=. When the linter is run on main once the PR is merged, no command line options are added.

Setting the --new-from-rev option to `HEAD~" does not resolve the unrelated lint errors that surface. It is unclear if the addition of the option is beneficial.

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? No

    • Did you notify the maintainers and provide attribution?

  2. Is this a breaking change? No

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? NA

codecov-commenter commented 1 year ago

Codecov Report

Merging #5316 (4b738e1) into main (fafd32c) will increase coverage by 0.02%. The diff coverage is 68.42%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #5316      +/-   ##
==========================================
+ Coverage   69.42%   69.44%   +0.02%     
==========================================
  Files         197      197              
  Lines       16091    16089       -2     
==========================================
+ Hits        11171    11173       +2     
+ Misses       4863     4859       -4     
  Partials       57       57
Flag Coverage Δ
unittests 69.44% <68.42%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/envoy/server/cache.go 0.00% <0.00%> (ø)
pkg/k8s/informers.go 87.71% <25.00%> (-2.46%) :arrow_down:
pkg/certificate/providers/mrc.go 50.00% <50.00%> (ø)
pkg/certificate/fake_manager.go 87.17% <100.00%> (ø)
pkg/certificate/manager.go 87.70% <100.00%> (ø)
pkg/certificate/providers/compat.go 86.66% <100.00%> (ø)
pkg/certificate/providers/config.go 79.51% <100.00%> (ø)
pkg/envoy/generator/cds/builder.go 81.00% <100.00%> (ø)
pkg/injector/exclusions.go 100.00% <100.00%> (ø)
pkg/injector/webhook.go 90.74% <100.00%> (+0.66%) :arrow_up:
... and 2 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.