openservicemesh / osm

Open Service Mesh (OSM) is a lightweight, extensible, cloud native service mesh that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
https://openservicemesh.io/
Apache License 2.0
2.58k stars 277 forks source link

fix(): missed lint err regarding unhandled error for addEventHandler #5317

Closed jaellio closed 1 year ago

jaellio commented 1 year ago

Description:

Fix the remaining unhandled error from the AddEventHandler call.

Related to #5306

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? No

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? No

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? No

codecov-commenter commented 1 year ago

Codecov Report

Merging #5317 (25403e5) into main (fafd32c) will increase coverage by 0.00%. The diff coverage is 25.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #5317   +/-   ##
=======================================
  Coverage   69.42%   69.42%           
=======================================
  Files         197      197           
  Lines       16091    16093    +2     
=======================================
+ Hits        11171    11173    +2     
  Misses       4863     4863           
  Partials       57       57           
Flag Coverage Δ
unittests 69.42% <25.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/k8s/informers.go 87.71% <25.00%> (-2.46%) :arrow_down:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.