openservicemesh / osm

Open Service Mesh (OSM) is a lightweight, extensible, cloud native service mesh that allows users to uniformly manage, secure, and get out-of-the-box observability features for highly dynamic microservice environments.
https://openservicemesh.io/
Apache License 2.0
2.59k stars 277 forks source link

Enable Apps Prometheus Metrics when OSM metrics is enabled #5332

Closed vimorra closed 1 year ago

vimorra commented 1 year ago

Please describe the Improvement and/or Feature Request The proposal is to enable the prometheus metrics both from OSM but also from the application point of view. Currently when OSM metrics are enabled in the namespace, as per documentation .

prometheus.io/scrape: true prometheus.io/port: 15010 prometheus.io/path: /stats/prometheus This disable the annotations values of the apps itself, and this means that application metrics are not scraped by prometheus. So the suggestion is to add a feature to enable the coexistence of multiple metrics endpoints

Scope (please mark with X where applicable)

Possible use cases An example scenario is in Azure AKS with Container Insight or the new managed promethus offering. https://learn.microsoft.com/en-us/azure/azure-monitor/containers/container-insights-prometheus?tabs=cluster-wide#prometheus-scraping-settings

github-actions[bot] commented 1 year ago

This issue will be closed due to a long period of inactivity. If you would like this issue to remain open then please comment or update.

github-actions[bot] commented 1 year ago

Issue closed due to inactivity.