opensheetmusicdisplay / opensheetmusicdisplay

OpenSheetMusicDisplay renders sheet music in MusicXML format in your web browser based on VexFlow. OSMD is brought to you by PhonicScore.com.
https://opensheetmusicdisplay.org
BSD 3-Clause "New" or "Revised" License
1.46k stars 289 forks source link

Tab Fingerings rendered/duplicated #1468

Closed sschmidTU closed 1 year ago

sschmidTU commented 1 year ago

We have been rendering fingerings in tab staffs for a while (which used to not be the case in earlier OSMD versions), which are often duplicated when having a combined classical+tab score, and aren't common in tabs.

The new default setting will be to not show fingerings in tabs.

Before:

image

After:

image

To show the fingerings (perhaps if you only have a single tab staff):

osmd.EngravingRules.TabFingeringsRendered = true

Similar issue: key and time signatures (#1467)

sschmidTU commented 1 year ago

visual regression diffs: tab-fingerings-disabled.zip

(only OSMD Function Test Tablature affected)