Closed jgyselov closed 1 year ago
@jgyselov: This pull request references MGMT-15330 which is a valid jira issue.
@jgyselov these changes don't affect tests for yaml's upload?
@jgyselov these changes don't affect tests for yaml's upload?
If it did, the test wouldn't pass without changes. (We are using the upload function in the tests, we are not typing the YAMLs manually.)
@jgyselov these changes don't affect tests for yaml's upload?
If it did, the test wouldn't pass without changes. (We are using the upload function in the tests, we are not typing the YAMLs manually.)
Perfect. Sorry, I wrote my comment before all tests passed. Good job
Perfect. Sorry, I wrote my comment before all tests passed.
I usually run the tests locally before I push to GH. So in case they fail, I can properly look into it right away. :slightly_smiling_face:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ammont82, jgyselov, jkilzi
The full list of commands accepted by this bot can be found here.
@talhil-rh FYI
https://issues.redhat.com/browse/MGMT-15330