openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

MGMT-15367: Custom manifests names should be unique #2277

Closed ammont82 closed 1 year ago

ammont82 commented 1 year ago

Related to https://issues.redhat.com/browse/MGMT-15367

Custom manifest files should be unique as openshift folder files are merged to manifests.

Before changes you can have same file name in different folders for custom manifests: Captura desde 2023-07-26 08-06-19

After changes you custom manifests file names should be unique regardless folder: Captura desde 2023-07-26 08-08-09

openshift-ci-robot commented 1 year ago

@ammont82: This pull request references MGMT-15367 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2277): >Related to https://issues.redhat.com/browse/MGMT-15367 > >Custom manifest files should be unique as openshift folder files are merged to manifests. > >Before changes you can have same file name in different folders for custom manifests: >![Captura desde 2023-07-26 08-06-19](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/962ccb9c-fd35-4a2d-8700-4b6b2942d950) > >After changes you custom manifests file names should be unique regardless folder: >![Captura desde 2023-07-26 08-08-09](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/a4b17c52-aa2e-4d8b-8bef-3929236c9b37) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jgyselov commented 1 year ago

There will be conflicts between this and #2278. I suggest we merge this one first.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment