search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 38 forks source link

MGMT-15332: Adding same name for 2 manifests - UI shows error on all manifests #2278

Closed jgyselov closed 1 year ago

jgyselov commented 1 year ago

https://issues.redhat.com/browse/MGMT-15332

In both screenshots, the manifests were called manifest1.yaml, manifest2.yaml, and manifest2.yaml.

Before:

image

After:

image

openshift-ci-robot commented 1 year ago

@jgyselov: This pull request references MGMT-15332 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2278): >https://issues.redhat.com/browse/MGMT-15332 > >**Before:** > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@jgyselov: This pull request references MGMT-15332 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2278): >https://issues.redhat.com/browse/MGMT-15332 > >In both screenshots, the manifests were called `manifest1.yaml`, `manifest2.yaml`, and `manifest2.yaml`. > >**Before:** > >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/87187179/bf563f67-05aa-459f-a005-85ab0eeadccd) > >**After:** > >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/87187179/9d33c2d9-0567-4435-9457-8f440a884cb5) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jgyselov commented 1 year ago

@jkilzi PTAL especially at the tests. Personally, I'm happy with the structure but not quite so sure about using the aliases.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

New changes are detected. LGTM label has been removed.