search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 38 forks source link

MGMT-15054: FCP devices (multipath) do not show correct size #2286

Closed jgyselov closed 1 year ago

jgyselov commented 1 year ago

https://issues.redhat.com/browse/MGMT-15054

If a disk has defined holders, it is not included in the total storage size calculations.

openshift-ci-robot commented 1 year ago

@jgyselov: This pull request references MGMT-15054 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2286): >https://issues.redhat.com/browse/MGMT-15054 > >If a disk has defined holders, it is not included in the total storage size calculations. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jgyselov commented 1 year ago

However, I have noticed that the function createHostInventoryWithDiskHolders does not really create fixtures with the expected master/workerDisk. It overwrites the disks with fixed data defined as disksWithHolders.

I suggest to fix it, perhaps by changing the function createHostInventoryWithDiskHolders (removing the declared diskSpace param, and send a dummy diskSpace value (eg. 0) to createHostInventory.). Or make diskHolders dynamic and use the received diskSpace.

I decided to remove the diskSpace parameter. I don't have the best understanding of how exactly the host inventory data works, I'm just using mock data provided here for the disks with holders.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment