search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

MGMT-11874: Simplifies the app routes #2312

Closed jkilzi closed 1 year ago

jkilzi commented 1 year ago
  1. Renames Router.tsx to Routes.tsx
  2. Exposing a single routes list (not a "router", that's a different thing...) that is already wrapped by our internal store.
  3. OCM's counterpart: https://gitlab.cee.redhat.com/service/uhc-portal/-/merge_requests/4454
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@jkilzi: This pull request references MGMT-11874 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2312): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@jkilzi: This pull request references MGMT-11874 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2312): >1. Renames `Router.tsx` to `Routes.tsx` >2. Exposing a single routes list (not a "router", that's a different thing...) that is already wrapped by our internal store. >3. OCM's counterpart: https://gitlab.cee.redhat.com/service/uhc-portal/-/merge_requests/4454 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.