search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

NO-ISSUE: Prepend build:all in start:watch_mode script #2316

Closed batzionb closed 1 year ago

batzionb commented 1 year ago

Setting up from scratch the project for integration with CIM following the readme, Revealed that the "yarn:watch_mode" command doesn't work without running "yarn build:all" before The solution chosen is to prepend build:all to the watch command

openshift-ci-robot commented 1 year ago

@batzionb: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2316): >Setting up from scratch the project for integration with CIM following the readme, >Revealed that the "yarn:watch_mode" command doesn't work without running "yarn build:all" before >The solution chosen is to prepend build:all to the watch command Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: batzionb, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

New changes are detected. LGTM label has been removed.