openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 37 forks source link

MGMT-15668: Cluster name and base domain name fields need to type something for trigger validations #2322

Closed jgyselov closed 1 year ago

jgyselov commented 1 year ago

https://issues.redhat.com/browse/MGMT-15668

Before:

https://github.com/openshift-assisted/assisted-installer-ui/assets/87187179/7759919a-22f6-4b10-ae52-431500857873

After:

https://github.com/openshift-assisted/assisted-installer-ui/assets/87187179/e67192e5-b606-49e5-b0d5-939115098282

openshift-ci-robot commented 1 year ago

@jgyselov: This pull request references MGMT-15668 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2322): >https://issues.redhat.com/browse/MGMT-15668 > >**Before:** > >https://github.com/openshift-assisted/assisted-installer-ui/assets/87187179/7759919a-22f6-4b10-ae52-431500857873 > >**After:** > >https://github.com/openshift-assisted/assisted-installer-ui/assets/87187179/e67192e5-b606-49e5-b0d5-939115098282 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ammont82 commented 1 year ago

@jgyselov these changes also affect CIM forms?

jgyselov commented 1 year ago

@jgyselov these changes also affect CIM forms?

Yes.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

New changes are detected. LGTM label has been removed.