openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 37 forks source link

MGMT-15570: Enable BMC form in Add hosts modal, for all platforms, if provisioning configuration exists #2323

Closed batzionb closed 1 year ago

batzionb commented 1 year ago

Provisioning configuration exists - BMC options are enabled with no help icon

No provisioning configuration - BMC options are disabled and there's a help icon explaining why and links to console default create page of Provisioning configuration

image

Provisioning configuration loading - BMC options are disabled and showing spinner

Peek 2023-09-04 16-26

Error loading Provisioning configuration - The BMC options are enabled and the error shows at the top of the modal image

openshift-ci-robot commented 1 year ago

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2323): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2323): >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/22211154/dcc3a36d-e6a5-4807-b08f-5a9c684a90cb) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2323): > >No provisioning configuration > >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/22211154/dcc3a36d-e6a5-4807-b08f-5a9c684a90cb) > >Provisioning configuration loading > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2323): >Provisioning configuration exists - BMC options are enabled with no help icon > >No provisioning configuration - BMC options are disabled and there's a help icon explaining why > >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/22211154/dcc3a36d-e6a5-4807-b08f-5a9c684a90cb) > >Provisioning configuration loading - BMC options are disabled and showing spinner > >![Peek 2023-09-04 16-26](https://github.com/openshift-assisted/assisted-installer-ui/assets/22211154/576b6c6a-ba39-442d-ab77-2392fd0f9640) > >Error loading Provisioning configuration - The BMC options are enabled and the error shows at the top of the modal >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/22211154/ee470bf0-80fc-44a7-bfb4-cdf3d807d88f) > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@batzionb: This pull request references MGMT-15570 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2323): >Provisioning configuration exists - BMC options are enabled with no help icon > >No provisioning configuration - BMC options are disabled and there's a help icon explaining why and links to console default create page of Provisioning configuration > >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/22211154/dcc3a36d-e6a5-4807-b08f-5a9c684a90cb) > >Provisioning configuration loading - BMC options are disabled and showing spinner > >![Peek 2023-09-04 16-26](https://github.com/openshift-assisted/assisted-installer-ui/assets/22211154/576b6c6a-ba39-442d-ab77-2392fd0f9640) > >Error loading Provisioning configuration - The BMC options are enabled and the error shows at the top of the modal >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/22211154/ee470bf0-80fc-44a7-bfb4-cdf3d807d88f) > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, batzionb, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

New changes are detected. LGTM label has been removed.