openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 35 forks source link

MGMT-14936: Remove user-managed-networking cluster attribute #2360

Closed ammont82 closed 11 months ago

ammont82 commented 11 months ago

Related to https://issues.redhat.com/browse/MGMT-14936

  1. For vsphere + umn/cmn we can save it in the state API that we have, If the user already set VIPs we know that he uses CMN

  2. We use these feature support levels: 'CLUSTER_MANAGED_NETWORKING', 'USER_MANAGED_NETWORKING'

    CLUSTER_MANAGED_NETWORKINGUSER_MANAGED_NETWORKINGOption selected by default
    SupportedUnsupportedCMN
    SupportedSupportedCMN
    UnsupportedSupportedUMN
  3. If the platform is none or baremetal UI needs to update the platform accordingly:

    • Choosing CMN will patch the cluster using: cluster.platform.type = "baremetal"
    • Choosing CMN will patch the cluster using: cluster.platform.type = "none"
openshift-ci-robot commented 11 months ago

@ammont82: This pull request references MGMT-14936 which is a valid jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2360): >Related to https://issues.redhat.com/browse/MGMT-14936 > >1. For vsphere + umn/cmn we can save it in the state API that we have, If the user already set VIPs we know that he uses CMN >2. We use these feature support levels: 'CLUSTER_MANAGED_NETWORKING', 'USER_MANAGED_NETWORKING' > > > > > >
CLUSTER_MANAGED_NETWORKINGUSER_MANAGED_NETWORKINGOption selected by default
SupportedUnsupportedCMN
SupportedSupportedCMN
UnsupportedSupportedUMN
> >3. If the platform is none or baremetal UI needs to update the platform accordingly: >- Choosing CMN will patch the cluster using: >cluster.platform.type = "baremetal" >- Choosing CMN will patch the cluster using: >cluster.platform.type = "none" > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jkilzi commented 11 months ago

please rebase

openshift-ci-robot commented 11 months ago

@ammont82: This pull request references MGMT-14936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2360): >Related to https://issues.redhat.com/browse/MGMT-14936 > >1. For vsphere + umn/cmn we can save it in the state API that we have, If the user already set VIPs we know that he uses CMN >2. We use these feature support levels: 'CLUSTER_MANAGED_NETWORKING', 'USER_MANAGED_NETWORKING' > > > > > >
CLUSTER_MANAGED_NETWORKINGUSER_MANAGED_NETWORKINGOption selected by default
SupportedUnsupportedCMN
SupportedSupportedCMN
UnsupportedSupportedUMN
> >3. If the platform is none or baremetal UI needs to update the platform accordingly: >- Choosing CMN will patch the cluster using: >cluster.platform.type = "baremetal" >- Choosing CMN will patch the cluster using: >cluster.platform.type = "none" > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 11 months ago

New changes are detected. LGTM label has been removed.

openshift-ci-robot commented 11 months ago

@ammont82: This pull request references MGMT-14936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2360): >Related to https://issues.redhat.com/browse/MGMT-14936 > >1. For vsphere + umn/cmn we can save it in the state API that we have, If the user already set VIPs we know that he uses CMN >2. We use these feature support levels: 'CLUSTER_MANAGED_NETWORKING', 'USER_MANAGED_NETWORKING' > > > > > >
CLUSTER_MANAGED_NETWORKINGUSER_MANAGED_NETWORKINGOption selected by default
SupportedUnsupportedCMN
SupportedSupportedCMN
UnsupportedSupportedUMN
> >3. If the platform is none or baremetal UI needs to update the platform accordingly: >- Choosing CMN will patch the cluster using: >cluster.platform.type = "baremetal" >- Choosing CMN will patch the cluster using: >cluster.platform.type = "none" > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 11 months ago

New changes are detected. LGTM label has been removed.