openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 35 forks source link

MGMT-15816: Use platform type to call support-levels API in Networking page - nutanix and vsphere leftovers #2372

Closed ammont82 closed 11 months ago

ammont82 commented 11 months ago

Related to https://issues.redhat.com/browse/MGMT-15816

Now, in Networking Page we disable/enable UMN or CMN depending calls of feature support levels API using new param platform_type:

  1. For example, for 'Nutanix' cluster: image

Then we can see this in Networking Page: image

openshift-ci-robot commented 11 months ago

@ammont82: This pull request references MGMT-15816 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2372): >Related to https://issues.redhat.com/browse/MGMT-15816 > >Now, in Networking Page we disable/enable UMN or CMN depending calls of feature support levels API using new param platform_type: >1. For example, for 'Nutanix' cluster: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/b04b9839-360f-41d6-8c43-af7fb544bb94) > >Then we can see this in Networking Page: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/a3ee85ac-9494-4f4a-a750-e063291d7d84) > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 11 months ago

@ammont82: This pull request references MGMT-15816 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2372): >Related to https://issues.redhat.com/browse/MGMT-15816 > >Now, in Networking Page we disable/enable UMN or CMN depending calls of feature support levels API using new param platform_type: >1. For example, for 'Nutanix' cluster: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/0d56f92d-e156-4819-825b-c02822cb7057) > >Then we can see this in Networking Page: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/a3ee85ac-9494-4f4a-a750-e063291d7d84) > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 11 months ago

@ammont82: This pull request references MGMT-15816 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2372): >Related to https://issues.redhat.com/browse/MGMT-15816 > >Now, in Networking Page we disable/enable UMN or CMN depending calls of feature support levels API using new param platform_type: >1. For example, for 'Nutanix' cluster: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/fc198503-bdd2-492e-828d-8376acad7664) > >Then we can see this in Networking Page: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/a3ee85ac-9494-4f4a-a750-e063291d7d84) > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 11 months ago

New changes are detected. LGTM label has been removed.