search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
10 stars 35 forks source link

MGMT-15871: Changing types in external API calls to use types from sdks package #2392

Closed ammont82 closed 9 months ago

ammont82 commented 9 months ago

Related to https://issues.redhat.com/browse/MGMT-15871

Change types from external API calls to use types generated inside sdks package.

Example:

openshift-ci-robot commented 9 months ago

@ammont82: This pull request references MGMT-15871 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2392): >Related to https://issues.redhat.com/browse/MGMT-15871 > >Change types from external API calls to use types generated inside sdks package. > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

@ammont82: This pull request references MGMT-15871 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2392): >Related to https://issues.redhat.com/browse/MGMT-15871 > >Change types from external API calls to use types generated inside sdks package. > >Example: >- Old types import: >import { Account } from '@openshift-assisted/types/accounts-management-service'; >- New types import: >import { Account } from '@openshift-assisted/sdks/accounts-management-service'; > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment