openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

Use full paths for react-icons and react-tokens #2447

Closed jschuler closed 9 months ago

jschuler commented 10 months ago

Cuts down OCM bundle by quite a bit

Should be done going forward! i.e No:

import { global_palette_green_500 as okColor } from '@patternfly/react-tokens';
import { ExclamationCircleIcon } from '@patternfly/react-icons';

Yes:

import { global_palette_green_500 as okColor } from '@patternfly/react-tokens/dist/js/global_palette_green_500';
import { ExclamationCircleIcon } from '@patternfly/react-icons/dist/js/icons/exclamation-circle-icon';

Before:

Screenshot 2023-12-05 at 10 05 39 AM

After:

Screenshot 2023-12-05 at 10 42 35 AM
openshift-ci[bot] commented 10 months ago

Welcome @jschuler! It looks like this is your first PR to openshift-assisted/assisted-installer-ui 🎉

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celdrake, jkilzi, jschuler

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 9 months ago

New changes are detected. LGTM label has been removed.