search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 35 forks source link

update peer dependencies #2448

Closed jschuler closed 7 months ago

jschuler commented 7 months ago

In OCM codebase:

Before ➜ uhc-portal git:(pf-v5-upgrade) ✗ npx check-peer-dependencies ❌ @openshift-console/dynamic-plugin-sdk 0.0.3 is required by @openshift-assisted/ui-lib@1.0.0) (0.0.19 is installed) ❌ react-dom ^17 is required by @openshift-assisted/ui-lib@1.0.0) (18.2.0 is installed) ✅ react-redux ^8.0.5 is required by @openshift-assisted/ui-lib@1.0.0 (8.1.1 is installed) ❌ react ^17 is required by @openshift-assisted/ui-lib@1.0.0) (18.2.0 is installed)

After ➜ uhc-portal git:(pf-v5-upgrade) ✗ npx check-peer-dependencies
✅ react-dom ^17 || ^18 is required by @openshift-assisted/ui-lib@1.0.0 (18.2.0 is installed) ✅ react-redux ^8.0.5 is required by @openshift-assisted/ui-lib@1.0.0 (8.1.1 is installed) ✅ react ^17 || ^18 is required by @openshift-assisted/ui-lib@1.0.0 (18.2.0 is installed)

Also @openshift-console/dynamic-plugin-sdk uses PF4, it's better as a dependency not peer-dep, since OCM is upgrading to PF5 (this lib is not used by OCM).

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jschuler, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ammont82 commented 7 months ago

@jschuler we approve the PR. Do we need to wait to merge until you do the changes for update PF 5?

openshift-ci[bot] commented 7 months ago

New changes are detected. LGTM label has been removed.