search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 35 forks source link

MGMT-16392: NTP text box allows to add empty string and browser freeze #2453

Closed ammont82 closed 6 months ago

ammont82 commented 6 months ago

Related to https://issues.redhat.com/browse/MGMT-16392

In the NTP dialog when we add an empty string we need to avoid browser freeze.

Captura desde 2023-12-13 09-18-10

openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-16392 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2453): >Related to https://issues.redhat.com/browse/MGMT-16392 > >In the NTP dialog when we add an empty string we need to avoid browser freeze. > >![Captura desde 2023-12-13 09-18-10](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/0e7dd8f8-8fc7-412a-8614-f7e669bd8b22) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-16392 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2453): >Related to https://issues.redhat.com/browse/MGMT-16392 > >In the NTP dialog when we add an empty string we need to avoid browser freeze. > >![Captura desde 2023-12-13 09-18-10](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/0e7dd8f8-8fc7-412a-8614-f7e669bd8b22) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 months ago

New changes are detected. LGTM label has been removed.