search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 35 forks source link

MGMT-16197: Change the way to download kubeconfig logs - followup #2458

Closed ammont82 closed 6 months ago

ammont82 commented 6 months ago

Related to https://issues.redhat.com/browse/MGMT-16197 Solves issue https://issues.redhat.com/browse/MGMT-16430 With last changes to download kubeconfig files, the browser was adding 'txt' extension to the downloaded file. We need to change the type when we create the blob data to download.

openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-16197 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2458): >Related to https://issues.redhat.com/browse/MGMT-16197 >With last changes to download kubeconfig files, the browser was adding 'txt' extension to the downloaded file. >We need to change the type when we create the blob data to download. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-16197 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2458): >Related to https://issues.redhat.com/browse/MGMT-16197 >With last changes to download kubeconfig files, the browser was adding 'txt' extension to the downloaded file. >We need to change the type when we create the blob data to download. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-16197 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2458): >Related to https://issues.redhat.com/browse/MGMT-16197 >Solves issue https://issues.redhat.com/browse/MGMT-16430 >With last changes to download kubeconfig files, the browser was adding 'txt' extension to the downloaded file. >We need to change the type when we create the blob data to download. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment