openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 35 forks source link

MGMT-16481: Add developer preview badge in external platform integration dropdown when platform is dev-preview #2467

Closed ammont82 closed 5 months ago

ammont82 commented 6 months ago

Related to https://issues.redhat.com/browse/MGMT-16481 OCP 4.11 + nutanix integration should have dev-preview badge in UI. We need to take into consideration the dev-preview from BE response in the external platform integration drodpdown.

image

openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-16481 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2467): >Related to https://issues.redhat.com/browse/MGMT-16481 >OCP 4.11 + nutanix integration should have dev-preview badge in UI. We need to take into consideration the dev-preview from BE response in the external platform integration drodpdown. > >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/e0c8a080-b659-477f-bf71-e41eedc134a6) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-16481 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2467): >Related to https://issues.redhat.com/browse/MGMT-16481 >OCP 4.11 + nutanix integration should have dev-preview badge in UI. We need to take into consideration the dev-preview from BE response in the external platform integration drodpdown. > >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/e0c8a080-b659-477f-bf71-e41eedc134a6) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jgyselov commented 6 months ago

The dev-preview badge is not clickable unless the item is disabled. Could you take a look at that?

https://github.com/openshift-assisted/assisted-installer-ui/assets/87187179/04a67008-6249-4a50-b9aa-eecba6237145

ammont82 commented 6 months ago

The dev-preview badge is not clickable unless the item is disabled. Could you take a look at that?

2024-01-04.10-30-50.mp4

I'll take a look. Thanks @jgyselov

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

New changes are detected. LGTM label has been removed.