search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 35 forks source link

upgrade PF5 from @openshift-assisted/ui-lib component #2470

Closed Ginxo closed 1 month ago

Ginxo commented 6 months ago

We recently upgraded OCM-UI application to PF5 and since OCM-UI is using @openshift-assisted/ui-lib@^2.29.0 PF4 and PF5 libraries are co-living and generating estrange behaviours or console errors

"@openshift-assisted/ui-lib@2.29.0":
  version "2.29.0"
  dependencies:
...
    "@patternfly/react-core" "^4.168.8"

See for instance https://issues.redhat.com/browse/OCMUI-124

Is this upgrading on your backlog? any due date for it?

Many thanks!

ammont82 commented 5 months ago

We are working on it. This is the task related: https://issues.redhat.com/browse/MGMT-16500

ammont82 commented 5 months ago

PR: https://github.com/openshift-assisted/assisted-installer-ui/pull/2477

ammont82 commented 1 month ago

@Ginxo Assisted UI Lib 2.31.7 was deployed to production and includes the change to PF5 styles.

Ginxo commented 1 month ago

thanks @ammont82 I see openshift-assisted/ui-lib still depends on @openshift-console/dynamic-plugin-sdk -> @patternfly/react-core:4.168.8 Any plan for this?

see information from yarn.lock

...
"@openshift-assisted/ui-lib@2.31.7":
  version "2.31.7"
  resolved "https://registry.yarnpkg.com/@openshift-assisted/ui-lib/-/ui-lib-2.31.7.tgz#82a216118512478685d469feabf9dde29340319f"
  integrity sha512-645yI89Lat1CsJukslMWFdqj3MFYViCMCR/y3Nz2ziEvHq7l1eXeA6pl0zwN6P7nQbffTX5SssvIY7IT31tsPg==
  dependencies:
    "@openshift-assisted/locales" "2.31.7"
    "@openshift-assisted/types" "2.31.7"
    "@openshift-console/dynamic-plugin-sdk" "0.0.3"
....

thanks @ammont82

ammont82 commented 1 month ago

I'll take a look @Ginxo