search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

MGMT-12995: Allow users to use custom OCP releases #2525

Closed ammont82 closed 6 months ago

ammont82 commented 6 months ago

Related to https://issues.redhat.com/browse/MGMT-12995

In order to allow users to select one of the legacy (not the latest) OpenShift releases, we need to list all available releases. For this, in Cluster creation page, the Openshift version dropdown only shows latest releases. If users wants to choose one of the legacy OCP releases then they can open a modal with all available releases and search the version that they need.

https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/9ecd15cd-ffde-44ed-baca-23aaeea6066f

openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-12995 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2525): >Related to https://issues.redhat.com/browse/MGMT-12995 > >In order to allow users to select one of the legacy (not the latest) OpenShift releases, we need to list all available releases. >For this, in Cluster creation page, the Openshift version dropdown only shows latest releases. If users wants to choose one of the legacy OCP releases then they can open a modal with all available releases and search the version that they need. > > >https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/9ecd15cd-ffde-44ed-baca-23aaeea6066f > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-12995 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2525): >Related to https://issues.redhat.com/browse/MGMT-12995 > >In order to allow users to select one of the legacy (not the latest) OpenShift releases, we need to list all available releases. >For this, in Cluster creation page, the Openshift version dropdown only shows latest releases. If users wants to choose one of the legacy OCP releases then they can open a modal with all available releases and search the version that they need. > > >https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/9ecd15cd-ffde-44ed-baca-23aaeea6066f > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ammont82 commented 6 months ago

@celdrake @jgyselov I've created a task to add tests: https://issues.redhat.com/browse/MGMT-17439

ammont82 commented 6 months ago

Functionality that is acting a bit weird:

  • There is no pre-selection of a default version anymore. When users open the "Create cluster" page, before the default version would be already selected.
  • In the main version dropdown, the block for "custom releases" appears even at the beginning, and it appears like there's an item and it can be hovered over, but it's empty and has no text.
  • The issue mentioned in another comment that the dividers in the modal dropdown appear for each version, not only to separate major version items.

These issues were solved with the last commit. I'll take a look to the problems with the dividers in the modal.

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment