search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

MGMT-17377: Change the way to validate field values in networking page #2534

Closed ammont82 closed 6 months ago

ammont82 commented 6 months ago

Related to https://issues.redhat.com/browse/MGMT-17377

Validate field values in Networking page:

Captura desde 2024-04-02 15-04-21 Captura desde 2024-04-02 15-04-14 Captura desde 2024-04-02 15-04-04

openshift-ci-robot commented 6 months ago

@ammont82: No Jira issue with key MGMT-173 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2534): >Related to https://issues.redhat.com/browse/MGMT-17377 > >Validate field values in Networking page: > > >![Captura desde 2024-04-02 15-04-21](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/247d4788-46c1-4447-8927-36d42d523a83) >![Captura desde 2024-04-02 15-04-14](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/0d5183cc-0250-4f58-b6eb-44a203a4097c) >![Captura desde 2024-04-02 15-04-04](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/431beaab-0f20-4583-b266-0baf1a6397b7) > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@ammont82: This pull request references MGMT-17377 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2534): >Related to https://issues.redhat.com/browse/MGMT-17377 > >Validate field values in Networking page: > > >![Captura desde 2024-04-02 15-04-21](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/247d4788-46c1-4447-8927-36d42d523a83) >![Captura desde 2024-04-02 15-04-14](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/0d5183cc-0250-4f58-b6eb-44a203a4097c) >![Captura desde 2024-04-02 15-04-04](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/431beaab-0f20-4583-b266-0baf1a6397b7) > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment