search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

MGMT-17473: Add scrollbar to OpenshiftVersionDropdown component #2542

Closed ammont82 closed 5 months ago

ammont82 commented 5 months ago

Related to https://issues.redhat.com/browse/MGMT-17473

Adding scrollbar to OpenshiftVersionDropdown component avoid problems about changing window layout.

Captura desde 2024-04-09 09-36-13

openshift-ci-robot commented 5 months ago

@ammont82: This pull request references MGMT-17473 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2542): >Related to https://issues.redhat.com/browse/MGMT-17473 > >Adding scrollbar to OpenshiftVersionDropdown component avoid problems about changing window layout. > >![Captura desde 2024-04-09 09-36-13](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/e73ef491-d290-4d9b-b40f-1303b0126dc6) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jgyselov commented 5 months ago

We are using the deprecated version of the Dropdown component. (See dropdown/react-deprecated vs dropdown.)

The newer version supports a flip behavior - if the dropdown doesn't have enough space bellow the toggle, it tries to render it above.

Maybe this is a good opportunity to migrate?

jgyselov commented 5 months ago

Also, I noticed that when we limit the height of the dropdown, the "Show all available versions" button is hidden at the bottom. I find that a bit unfortunate.

ammont82 commented 5 months ago

We are using the deprecated version of the Dropdown component. (See dropdown/react-deprecated vs dropdown.)

The newer version supports a flip behavior - if the dropdown doesn't have enough space bellow the toggle, it tries to render it above.

Maybe this is a good opportunity to migrate?

@jgyselov is not so easy migrate to new Dropdown version. It implies a lot of changes and we need to take a look carefully. I'll open a task to do in the future.

openshift-ci[bot] commented 5 months ago

New changes are detected. LGTM label has been removed.