search

openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 35 forks source link

MGMT-17477: Show dev preview badge when select custom OCP versions #2543

Closed ammont82 closed 2 months ago

ammont82 commented 2 months ago

Related to https://issues.redhat.com/browse/MGMT-17477

https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/fba5ade4-73e3-4243-973d-5d5f5a4af4fa

openshift-ci-robot commented 2 months ago

@ammont82: This pull request references MGMT-17477 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2543): >Related to https://issues.redhat.com/browse/MGMT-17477 > > >https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/fba5ade4-73e3-4243-973d-5d5f5a4af4fa > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jgyselov commented 2 months ago

While we're at it, I think we should show the Please note that this version is not production-ready. warning when a dev-preview version is selected trough the modal. (It's currently missing.)

ammont82 commented 2 months ago

I agree with @jgyselov

Selecting the same version, eg. 4.16.0-ec.4-multi, should work the same way whether it's selected via the custom or main dropdown.

Currently, with the custom dropdown, the badge is missing. It's OK to add the "dev preview" label, but I think the badge is more relevant.

@jgyselov @celdrake now it works. It was a problem with the updating of helper text.