[OCMUI-1145] PreviewBadge: allow ReactNode content

cben commented 2 months ago

Motivation: In OCM we have use case for showing dynamic badge content (https://issues.redhat.com/browse/OCMUI-1145) where we don't get separate "Learn More" URL but might render links in the text itself.

The existing PreviewBadge component supports this fine at run time, only the popoverText: string type was too restrictive at compile time.

Relaxed the type.
Renamed popoverText -> popoverContent accordingly. Can drop this part if there is any concern?

With the ongoing de-coupling of our codebases, I'm not sure we'll end up using this — but seems harmless enough?

[ ] UNTESTED — I don't have AI dev setup, didn't manage to run unit tests even on master (Missing internal module 'internal/deps/./lib/client'...)
[x] yarn build:all passed.

cben commented 2 months ago

@ammont82 please review

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, cben, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.

openshift-assisted / assisted-installer-ui

[OCMUI-1145] PreviewBadge: allow ReactNode content #2560