openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

MGMT-17955: Show the correct icon next to the nodes #2587

Closed ammont82 closed 4 months ago

ammont82 commented 4 months ago

Related to https://issues.redhat.com/browse/MGMT-17955

With latest changes, warning sign/icon appears next to the nodes although should be green. It seems it's a wrong condition in HostStatus file.

Before: image

After: image

openshift-ci-robot commented 4 months ago

@ammont82: This pull request references MGMT-17955 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2587): >Related to https://issues.redhat.com/browse/MGMT-17955 > >With latest changes, warning sign/icon appears next to the nodes although should be green. It seems it's a wrong condition in HostStatus file. > >Before: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/6d34c05b-c9e7-4d86-9ee4-50a8b02c0197) > >After: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/57a644a2-426c-420e-b2fd-dbf4f51e6653) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 months ago

@ammont82: This pull request references MGMT-17955 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2587): >Related to https://issues.redhat.com/browse/MGMT-17955 > >With latest changes, warning sign/icon appears next to the nodes although should be green. It seems it's a wrong condition in HostStatus file. > >Before: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/6d34c05b-c9e7-4d86-9ee4-50a8b02c0197) > >After: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/57a644a2-426c-420e-b2fd-dbf4f51e6653) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 months ago

@ammont82: This pull request references MGMT-17955 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2587): >Related to https://issues.redhat.com/browse/MGMT-17955 > >With latest changes, warning sign/icon appears next to the nodes although should be green. It seems it's a wrong condition in HostStatus file. > >Before: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/6d34c05b-c9e7-4d86-9ee4-50a8b02c0197) > >After: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/77945104-67f5-4157-b3ee-219ecdc6763c) > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment