openshift-assisted / assisted-installer-ui

The Assisted Installer User Interface
https://console.redhat.com/openshift/create/datacenter
Apache License 2.0
9 stars 36 forks source link

NO-ISSUE: Adapting code for decoupling tasks #2592

Closed ammont82 closed 2 months ago

ammont82 commented 4 months ago

Testing decoupling inside uhc-portal I found these errors: image

It seems a problem with component. I've changed the way is used inside ClusterBreadcrumbs and BackButton.

openshift-ci-robot commented 4 months ago

@ammont82: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift-assisted/assisted-installer-ui/pull/2592): >Testing decoupling inside uhc-portal I found these errors: >![image](https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/790e96dc-39ec-43bc-b678-7c0329fb4c6b) > >It seems a problem with component. >I've changed the way is used inside BreadCrumbs and BackButton. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift-assisted%2Fassisted-installer-ui). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ammont82 commented 3 months ago

Link component from react-router-dom instead of react-router-dom-v5-compat ?

I tested it but not works. Running locally I saw this error "You should not use outside a ". Still working on it, trying to find a better solution

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-assisted/assisted-installer-ui/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.