search

openshift-cloud-functions / knative-operators

Integration for Knative and the Operator Lifecycle Manager
Apache License 2.0
21 stars 27 forks source link

Kiali password should not be hardcoded #17

Open bbrowning opened 5 years ago

bbrowning commented 5 years ago

https://github.com/openshift-cloud-functions/knative-operators/blob/v0.2/etc/scripts/installation-functions.sh#L162

Ideally we could flip a setting in Kiali to have it just oauth against OpenShift's oauth server. I'm not sure if Kiali supports that, but 'admin/admin' isn't a good idea as this can be used to run on OCP/OKD clusters now and not just minishift.

jcrossley3 commented 5 years ago

Worth tracking here, of course, but isn't this more an issue with the maistra-operator?

bbrowning commented 5 years ago

Well, we're the ones setting the password here. We could just as easily set it to some random string.

jcrossley3 commented 5 years ago

An auto-generated string or just something other than 'admin'?

On Fri, Jan 25, 2019 at 1:08 PM Ben Browning notifications@github.com wrote:

Well, we're the ones setting the password here. We could just as easily set it to some random string.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/openshift-cloud-functions/knative-operators/issues/17#issuecomment-457665194, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAj_ZXNqwd30Mt9mt7DbAm3N7TnzIxRks5vG0glgaJpZM4aMo7x .