openshift-cnv / cnv-fbc

0 stars 15 forks source link

The candidate bundles should already be publically available #3

Closed tiraboschi closed 1 year ago

tiraboschi commented 1 year ago

If I try adding a candidate bundle with its expected finale address, opm currently fails:

stirabos@t14s:~/cnv-fbc$ ./generate-fbc.sh test
Current OPM version is: Version: version.Version{OpmVersion:"v1.26.4", GitCommit:"57a959da", BuildDate:"2023-02-21T17:31:26Z", GoOs:"linux", GoArch:"amd64"}
Requires OPM v1.26.3+
2023/03/22 17:32:45 render reference "registry.redhat.io/container-native-virtualization/hco-bundle-registry@sha256:f1abed840dba11a1d05e2a89b9d2cb4c14d795144c8f49eb1f0155a966153aac": error resolving name for image ref registry.redhat.io/container-native-virtualization/hco-bundle-registry@sha256:f1abed840dba11a1d05e2a89b9d2cb4c14d795144c8f49eb1f0155a966153aac: registry.redhat.io/container-native-virtualization/hco-bundle-registry@sha256:f1abed840dba11a1d05e2a89b9d2cb4c14d795144c8f49eb1f0155a966153aac: not found

we can use the URL on the brew registry, but then something has to post-process it before publishing.

gallettilance commented 1 year ago

yeah you would need to have a post-processing script to update the registry and repo name (which should only be in a single location (the bundle image name) in the FBC)

tiraboschi commented 1 year ago

s|brew.registry.redhat.io|registry.redhat.io|g ?

tiraboschi commented 1 year ago

done