openshift-cs / devcenter

Developer Center
https://developers.openshift.com
14 stars 34 forks source link

global: add travis with auto deployments #435

Closed jsvgoncalves closed 8 years ago

jsvgoncalves commented 8 years ago

Signed-off-by: Joao Goncalves jsvgoncalves@gmail.com

jsvgoncalves commented 8 years ago

@developercorey @luciddreamz please review

coreydaley commented 8 years ago

@jsvgoncalves Instead of having id_rsa_deploy.enc in the repo, why don't we store the key we use for deployment as an environment variable in the travis-ci settings like we do for the settings to decrypt this key and use it? Wouldn't that be safer? Less likely someone could download it and brute force it.

jsvgoncalves commented 8 years ago

@developercorey

data too large - consider using travis encrypt-file or travis env set

coreydaley commented 8 years ago

Ok, that makes sense

coreydaley commented 8 years ago

Looks good to me unless @luciddreamz has any comments

luciddreamz commented 8 years ago

Looks good