openshift-eng / elliott

Apache License 2.0
15 stars 28 forks source link

find-bugs:sweep: don't exit with 0 on error #467

Closed vfreex closed 1 year ago

vfreex commented 1 year ago

Will try to avoid to directly use exit code. Let's raise an Exception to the top level instead.

openshift-bot commented 1 year ago

Build #1

GLOB sdist-make: /mnt/workspace/jenkins/working/art-tools_elliott_PR-467/setup.py
py38 create: /mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/py38
py38 installdeps: -rrequirements-dev.txt
py38 inst: /mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/.tmp/package/1/rh-elliott-2.0.14.dev186+geea2358.zip
py38 installed: aiodns==3.0.0,aiohttp==3.8.3,aiosignal==1.3.1,astroid==2.12.13,async-timeout==4.0.2,attrs==22.1.0,Brotli==1.0.9,cchardet==2.1.7,certifi==2022.9.24,cffi==1.15.1,charset-normalizer==2.1.1,click==8.1.3,coverage==6.5.0,cryptography==38.0.3,decorator==5.1.1,defusedxml==0.7.1,dill==0.3.6,distlib==0.3.6,errata-tool==1.29.0,exceptiongroup==1.0.4,filelock==3.8.0,flake8==6.0.0,flexmock==0.11.3,frozenlist==1.3.3,future==0.18.2,gssapi==1.8.2,idna==3.4,iniconfig==1.1.1,isort==5.10.1,jira==3.4.1,jsonpath-rw==1.4.0,koji==1.31.0,krb5==0.4.1,lazy-object-proxy==1.8.0,mccabe==0.7.0,mock==4.0.3,multidict==6.0.2,mypy==0.991,mypy-extensions==0.4.3,oauthlib==3.2.2,packaging==21.3,platformdirs==2.5.4,pluggy==1.0.0,ply==3.11,py==1.11.0,pycares==4.2.2,pycodestyle==2.10.0,pycparser==2.21,pyflakes==3.0.0,pygit2==1.10.1,pylint==2.15.6,pyparsing==3.0.9,pyspnego==0.6.3,pytest==7.2.0,python-bugzilla==3.2.0,python-dateutil==2.8.2,PyYAML==6.0,requests==2.28.1,requests-gssapi==1.2.3,requests-kerberos==0.14.0,requests-oauthlib==1.3.1,requests-toolbelt==0.10.1,rh-elliott @ file:///mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/.tmp/package/1/rh-elliott-2.0.14.dev186%2Bgeea2358.zip,ruamel.yaml==0.17.21,ruamel.yaml.clib==0.2.7,semver==2.13.0,setuptools-scm==7.0.5,six==1.16.0,tenacity==8.1.0,tomli==2.0.1,tomlkit==0.11.6,tox==3.27.1,typing_extensions==4.4.0,urllib3==1.26.13,virtualenv==20.16.7,wrapt==1.14.1,yarl==1.8.1
py38 run-test-pre: PYTHONHASHSEED='971571663'
py38 run-test: commands[0] | coverage run --branch --source elliottlib -m unittest discover -t . -s tests/
................................................BZ 9 is ignored because its status was MODIFIED at the moment of sweep cutoff (2021-06-30 12:30:00), however its status changed back to ['ASSIGNED'] afterwards
.....................No flaw bugs could be found for these trackers: {'OCPBUGS-2'}
...changed 123 from status1 to status2
.123 is already on status1
.changed 123 from status1 to status2
..changed 123 from status1 to status2
.123 is already on status1
.changed 123 from status1 to status2
........................../mnt/workspace/jenkins/working/art-tools_elliott_PR-467/elliottlib/errata_async.py:39: RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
  resp.raise_for_status()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
................F...../mnt/workspace/jenkins/working/art-tools_elliott_PR-467/elliottlib/cli/find_bugs_sweep_cli.py:267: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
  logger.warn(f"Bug {warning_bug} has CVE number in summary but does not have tracker keywords")
Bug ['OCPBUGS-4', 'OCPBUGS-5'] has CVE number in summary but does not have tracker keywords
...........................................
======================================================================
FAIL: test_find_bugs_sweep_advisory_jira (tests.test_find_bugs_sweep_cli.FindBugsSweepTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/workspace/jenkins/working/art-tools_elliott_PR-467/tests/test_find_bugs_sweep_cli.py", line 140, in test_find_bugs_sweep_advisory_jira
    self.fail(t)
AssertionError: Traceback (most recent call last):

  File "/mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/py38/lib/python3.8/site-packages/click/testing.py", line 408, in invoke
    return_value = cli.main(args=args or (), prog_name=prog_name, **extra)

  File "/mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/py38/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)

  File "/mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/py38/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))

  File "/mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/py38/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)

  File "/mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/py38/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)

  File "/mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/py38/lib/python3.8/site-packages/click/decorators.py", line 38, in new_func
    return f(get_current_context().obj, *args, **kwargs)

  File "/mnt/workspace/jenkins/working/art-tools_elliott_PR-467/elliottlib/cli/find_bugs_sweep_cli.py", line 140, in find_bugs_sweep_cli
    raise ElliottFatalError(f"Error finding or attaching bugs: {errors}. See logs for more information.")

elliottlib.exceptions.ElliottFatalError: Error finding or attaching bugs: [AttributeError("'MockClass' object has no attribute 'is_tracker_bug'"), AttributeError("'MockClass' object has no attribute 'is_tracker_bug'")]. See logs for more information.

----------------------------------------------------------------------
Ran 168 tests in 0.730s

FAILED (failures=1)
ERROR: InvocationError for command /mnt/workspace/jenkins/working/art-tools_elliott_PR-467/.tox/py38/bin/coverage run --branch --source elliottlib -m unittest discover -t . -s tests/ (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   py38: commands failed