openshift-evangelists / oc-cluster-wrapper

oc cluster up bash wrapper
Apache License 2.0
144 stars 72 forks source link

Not possible to set the public hostname on linux #31

Closed siamaksade closed 7 years ago

siamaksade commented 7 years ago

Setting the public hostname via OC_CLUSTER_PUBLIC_HOSTNAME is ignored by the script and it's overridden by setting it to $(which-ip docker0) in the plugins branch: https://github.com/openshift-evangelists/oc-cluster-wrapper/blob/plugins/oc-cluster#L28

jorgemoralespou commented 7 years ago

@siamaksade are you testing on mac, linux or both?

siamaksade commented 7 years ago

This happens on linux. I have tested on CentOS 7

jorgemoralespou commented 7 years ago

This should be fixed. Can you test. Also plugins branch is merged, so many enhancements done here.

csrwng commented 7 years ago

@jorgemoralespou I tried it on my linux machine (RHEL 7) and I ran into this as well. I cannot override the public hostname