openshift-evangelists / oc-cluster-wrapper

oc cluster up bash wrapper
Apache License 2.0
144 stars 72 forks source link

Size option for creating volumes not used. #4

Closed GrahamDumpleton closed 8 years ago

GrahamDumpleton commented 8 years ago

Code has:

  local __size=$2

but then doesn't use it in YAML.

cat <<-EOF > /tmp/pv.yaml
apiVersion: v1
kind: PersistentVolume
metadata:
  name: ${__volume}
spec:
  capacity:
    storage: 10Gi
  accessModes:
    - ReadWriteOnce
    - ReadWriteMany
  persistentVolumeReclaimPolicy: Recycle
  hostPath:
    path: ${__path}
EOF

So always set to 10Gi.

Only of issue if you wanted to play with what happens when have different sizes. Going to be able to grow beyond that to all available space anyway.

jorgemoralespou commented 8 years ago

This was unfinished. The idea was to be able to set size and path. And possibly more things in the future.

El 23 sept. 2016 6:19, "Graham Dumpleton" notifications@github.com escribió:

Code has:

local __size=$2

but then doesn't use it in YAML.

cat <<-EOF > /tmp/pv.yaml apiVersion: v1 kind: PersistentVolume metadata: name: ${__volume} spec: capacity: storage: 10Gi accessModes:

  • ReadWriteOnce
  • ReadWriteMany persistentVolumeReclaimPolicy: Recycle hostPath: path: ${__path} EOF

So always set to 10Gi.

Only of issue if you wanted to play with what happens when have different sizes. Going to be able to grow beyond that to all available space anyway.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jorgemoralespou/oc-cluster-wrapper/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEyDhRyj6oybybVWMxTPk_cEH8rmU1Xks5qs1M4gaJpZM4KEmPN .