search

openshift-evangelists / oc-cluster-wrapper

oc cluster up bash wrapper
Apache License 2.0
144 stars 72 forks source link

Script uses --host-pv-dir instead of --host-volumes-dir #45

Closed wkulhanek closed 7 years ago

wkulhanek commented 7 years ago

When spinning up a cluster the script writes the start command into ..../profiles/name/run. But it writes --host-pv-dir which is not a valid option. Therefore subsequent cluster starts fail.

Tested on oc 3.4.0.39 and 3.4.0.40.

jorgemoralespou commented 7 years ago

@wkulhanek have you updated the tool? This should have been fixed already.

Can you paste the output of:

git show --oneline -s
jorgemoralespou commented 7 years ago

@wkulhanek Just validated that it works.

This is my output:

$ oc-cluster up ocp-34 --image='registry.access.redhat.com/openshift3/ose' --version='v3.4.0.40'
[INFO] Running a new cluster
oc cluster up --public-hostname 127.0.0.1 --routing-suffix apps.lcup --host-data-dir /Users/jmorales/.oc/profiles/ocp-34/data --host-config-dir /Users/jmorales/.oc/profiles/ocp-34/config --use-existing-config -e TZ=CET --image=registry.access.redhat.com/openshift3/ose --version=v3.4.0.40
wkulhanek commented 7 years ago

Did pull the latest and sure enough it works. Thought I had done that before but I guess not. :-) Thanks for checking.