search

openshift-evangelists / oc-cluster-wrapper

oc cluster up bash wrapper
Apache License 2.0
144 stars 72 forks source link

Added Nexus3 and Imagestreams Plugins #47

Closed wkulhanek closed 7 years ago

wkulhanek commented 7 years ago

I added plugins for Nexus3 and Image Streams. Nexus3 is creating a Nexus 3 installation rather than the Nexus 2 installation that is already included.

Image Streams removes all the image streams and then imports the Red Had Image Streams - which is useful when developing for OpenShift Container Platform rather than for Origin.

wkulhanek commented 7 years ago

Just updated the Image Streams Plugin to also include all Red Hat Templates.

jorgemoralespou commented 7 years ago

@wkulhanek Can you split this PR into two.

The one for nexus3 I'll merge it right away, the one for the imagestreams, will need some work.

Just FYI, origin/ocp oc client for version 1.5/3.5 has already the option to select which Imagestream to install, so that means that if you use the origin client, by default you'll get the origin imagestreams, if you use the ocp client you'll get the red hat imagestreams, but you'll always be able to select the other.

      --image-streams='centos7': Specify which image streams to use, centos7|rhel7

For now, I would prefer to have 2 plugins or one plugin with an option to install the appropriate imagestreams so you can get the other in case you have started the cluster with an ocp client and want the origin imagestreams. Maybe provide an option to delete all previous imagestreams.

I would not delete the openshift namespace, but rather replace the existing imagestreams. What I've seen is that there is people that want to add the wildfly to an enteprise install, or the products to an origin install.

And lastly, if the version of the imagestreams is important, I would have that as an argument as well, or taken from the oc version that you're running. (For that I might need to add a function, which I could do).

jorgemoralespou commented 7 years ago

@wkulhanek There's another issue with similar request by @wpernath in https://github.com/openshift-evangelists/oc-cluster-wrapper/issues/48

it would be cool if this PR fixes what you want in the best way. Looking at Wanja's request, it seems like other imagestreams.