openshift-evangelists / oc-cluster-wrapper

oc cluster up bash wrapper
Apache License 2.0
144 stars 72 forks source link

oc-cluster engineer branch #56

Closed csrwng closed 7 years ago

csrwng commented 7 years ago

Pull request for changes in oc-cluster-engineers branch

csrwng commented 7 years ago

@jorgemoralespou I created a PR from your branch so I can comment on your changes

csrwng commented 7 years ago

Here is my mounts-template.json:

{
  "bindMounts": [
    {
      "imagePattern": "(openshift/origin$)|(openshift/origin:.*)",
      "mounts": [
        {
          "source": "$OPENSHIFT_BINARY",
          "destination": "/usr/bin/openshift"
        }
      ]
    },
    {
      "imagePattern": "openshift/origin-deployer.*",
      "mounts": [
        {
          "source": "$OPENSHIFT_BINARY",
          "destination": "/usr/bin/openshift"
        }
      ]
    },
    {
      "imagePattern": "openshift/origin-recycler.*",
      "mounts": [
        {
          "source": "$OPENSHIFT_BINARY",
          "destination": "/usr/bin/openshift"
        }
      ]
    },
    {
      "imagePattern": "openshift/origin-docker-builder.*",
      "mounts": [
        {
          "source": "$OPENSHIFT_BINARY",
          "destination": "/usr/bin/openshift"
        }
      ]
    },
    {
      "imagePattern": "openshift/origin-sti-builder.*",
      "mounts": [
        {
          "source": "$OPENSHIFT_BINARY",
          "destination": "/usr/bin/openshift"
        }
      ]
    },
    {
      "imagePattern": "openshift/origin-f5-router.*",
      "mounts": [
        {
          "source": "$OPENSHIFT_BINARY",
          "destination": "/usr/bin/openshift"
        }
      ]
    },
    {
      "imagePattern": "openshift/node.*",
      "mounts": [
        {
          "source": "$OPENSHIFT_BINARY",
          "destination": "/usr/bin/openshift"
        }
      ]
    },
  ]
}
csrwng commented 7 years ago

I get this on RHEL...

Running in developer mode, using DOCKER_HOST=tcp://172.17.0.1:2375
/root/oc-cluster-wrapper/oc-cluster: line 526: DOCKER_HOST=tcp://172.17.0.1:2375: No such file or directory
[ERROR] Cluster has not started correctly. Profile configuration will be preserved

Will submit a fix PR to your branch

jorgemoralespou commented 7 years ago

@csrwng I have installed a linux box and have been testing on linux to fix the issues. They should now work, also deleting the profile works.

I think it's ready to go.

csrwng commented 7 years ago

@jorgemoralespou maybe it's the bash version on my RHEL box, but I get this when running oc-cluster status:

Using client for origin v1.5.0-alpha.3
/root/oc-cluster-wrapper/oc-cluster: line 669: syntax error near unexpected token `fi'
/root/oc-cluster-wrapper/oc-cluster: line 669: `     fi'
csrwng commented 7 years ago

Looks like there shouldn't be an if on line 661

jorgemoralespou commented 7 years ago

@csrwng Yes, sorry for that. I tested before making the if test not use the if and forgot to remove that if statement. Now it's been removed.

csrwng commented 7 years ago

@jorgemoralespou LGTM ... tested with your latest changes and things are working for me.