search

openshift-evangelists / oc-cluster-wrapper

oc cluster up bash wrapper
Apache License 2.0
144 stars 72 forks source link

--http-proxy, --https-proxy, --no-proxy doesn't really do anything #82

Open michalkutyla opened 6 years ago

michalkutyla commented 6 years ago

Hi, nice project Jorg!

Maybe I'm missing something but it looks like proxy parameters are parsed and then ignored. I patched it on my machine by adding

if [ ! -z $PARM_OC_HTTP_PROXY ]; then CMDLINE+=" --http-proxy=$__PARM_OC_HTTP_PROXY" fi if [ ! -z $PARM_OC_HTTPS_PROXY ]; then CMDLINE+=" --https-proxy=$PARM_OC_HTTPS_PROXY" fi if [ ! -z $__PARM_OC_NO_PROXY ]; then CMDLINE+=" --no-proxy=$PARM_OC_NO_PROXY" fi

If you like it, I will submit a pull request.

Cheers, Michal

jorgemoralespou commented 6 years ago

Please do. I introduce these commands before the feature was available on oc cluster up, and nobody reminded me about it, and I forgot, since I don't use a proxy.

cmcconnell1 commented 6 years ago

Hello, and thanks for this project/tool. This is very useful.

For anyone else running into docker proxy issues (on MACOS/OSX), it appears as though recent versions (a few months ago) have added a proxy that cannot be disabled and this is causing workflows to break, etc.

Details, workarounds and related/open issues: https://github.com/openshift/origin/issues/18596

Thanks, -cmcc