search

openshift-evangelists / openshift-workshops

[DEPRECATED] Use workshopper https://github.com/openshift-evangelists/workshopper
17 stars 35 forks source link

fixed some typos #10

Closed juhoffma closed 8 years ago

juhoffma commented 8 years ago

Running through the labs, I noticed, that there are some inconsistencies within our naming convention meaning, that the ansible script deploys projects with the name explore-user00…explore-userXX and in some outputs we still write explore-XX

marekjelen commented 8 years ago

+1

siamaksade commented 8 years ago

Good point but the project names shouldn't be hard-coded. Instead "explore{{USER_SUFFIX}}" should be use so that we can change that through the lab definitions.

juhoffma commented 8 years ago

Will change

--  Jürgen Hoffmann Sent with Airmail

From: Marek Jelen notifications@github.com Reply: openshift-evangelists/openshift-workshops reply@reply.github.com Date: 3. November 2016 at 10:12:19 To: openshift-evangelists/openshift-workshops openshift-workshops@noreply.github.com Cc: Juergen Hoffmann hoffmann@ellumination.de, Author author@noreply.github.com Subject:  Re: [openshift-evangelists/openshift-workshops] fixed some typos (#10)

+1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

juhoffma commented 8 years ago

Done. Please review and merge

siamaksade commented 8 years ago

👍