search

openshift-evangelists / workshopper

Workshop content rendering tool
63 stars 41 forks source link

Consolidate env vars for content #3

Closed siamaksade closed 7 years ago

siamaksade commented 7 years ago

Is there a need to keep all the three content env vars?

CONTENT_URL_PREFIX essential satisfies the requirement for pulling content from other repositories.

siamaksade commented 7 years ago

@marekjelen

marekjelen commented 7 years ago

The GITHUB_* are there to simplify the construction of CONTENT_URL_PREFIX for github users as it is not the github repo url but link to raw data on the CDN.

marekjelen commented 7 years ago

@siamaksade can we close this?

siamaksade commented 7 years ago

+1

On Tue, 28 Feb 2017 at 08:49, Marek Jelen notifications@github.com wrote:

@siamaksade https://github.com/siamaksade can we close this?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/osevg/workshopper/issues/3#issuecomment-282967254, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHtlvIXUtxgD_zU2VFHEqLl_-jYci8xks5rg9GDgaJpZM4Lz1lZ .

marekjelen commented 7 years ago

thanks