openshift-evangelists / workshopper

Workshop content rendering tool
63 stars 41 forks source link

admonition text and list definition text is bigger than normal paragraph text #44

Closed thoraxe closed 6 years ago

thoraxe commented 6 years ago

When using admonitions (eg: NOTE:) or definition lists (eg: <2>), the resulting text on the page has a larger size than normal paragraph text.

I'm seeing a computed text size for admonitions and DLs as 16px, whereas regular paragraph text is 14px.

I'd think this should all be the same?

thesteve0 commented 6 years ago

Admonitions should definitely be larger as they are intended to catch the users eye. They are larger, bold, and usually have an icon when rendered in asciidoctor or in the O'Reilly atlas system. I am not sure with list items

Coming at you from my phone, please excuse typos, poor grammar, curtness, and dashing good looks

On Oct 5, 2017 2:49 PM, "Erik M Jacobs" notifications@github.com wrote:

When using admonitions (eg: NOTE:) or definition lists (eg: <2>), the resulting text on the page has a larger size than normal paragraph text.

I'm seeing a computed text size for admonitions and DLs as 16px, whereas regular paragraph text is 14px.

I'd think this should all be the same?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openshift-evangelists/workshopper/issues/44, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVsw6Pn1SrMI_1jPfaSKO49DontAWySks5spU7PgaJpZM4Pvv2c .

marekjelen commented 6 years ago

Cleaned up the CSS in new version, will release ASAP for testing.