openshift-helm-charts / development

0 stars 17 forks source link

Fix bug in PR comment generation caused by missing step ID #280

Closed komish closed 1 year ago

komish commented 1 year ago

Addresses the bug in PR https://github.com/openshift-helm-charts/charts/issues/881 - can't close it from here because it's in the production repository. Will close it manually when this merges.

This is also marked as a draft because of the ongoing release. I did not want to kick off workflows while the release testing was running.


This PR addresses a bug in our PR commenting, where we would wrongly indicate to the user that something went wrong, and proceed to merge their PR as expected since nothing actually went wrong.

This was caused by an environment variable that was never set because the link to the corresponding step (by ID) was broken. This PR addresses this, and the comment now looks correct when the OC installation failure takes place.

E.g.

Thank you for submitting PR #9999 for Helm Chart Certification!

Unfortunately the certification process failed to install OpenShift Client and could not complete.

This problem will be addressed by maintainers and no further action is required from the submitter at this time.

---

For information on the certification process see:
- [Red Hat certification requirements and process for Kubernetes applications that are deployed using Helm charts.](https://redhat-connect.gitbook.io/partner-guide-for-red-hat-openshift-and-container/helm-chart-certification/overview).

For support, connect with our [Technology Partner Success Desk](https://redhat-connect.gitbook.io/red-hat-partner-connect-general-guide/managing-your-account/getting-help/technology-partner-success-desk).

/metadata {"vendor_label": "concerthall", "chart_name": "gosnappass"}