search

openshift-helm-charts / development

0 stars 17 forks source link

Display error messages for each failure #286

Open mgoerens opened 1 year ago

mgoerens commented 1 year ago

Currently, only the error message related to the first failing step is communicated to the user.

See https://github.com/openshift-helm-charts/development/blob/dcce7a5b4b94560c13dfba9a4b8e13f4ad6b54e4/scripts/src/pullrequest/prepare_pr_comment.py#L233-L256

We should consider displaying error messages for each failure that was received rather than only for the first one.

OchiengEd commented 10 months ago

This appears doable. From reviewing the snippet shared, it seems that would mean breaking the conditions to be separate. So that each of the failures could be evaluated independently.