Closed mgoerens closed 10 months ago
Comes from this discussion
Currently, the step that prepares the PR comment uses the oc-install.conclusion value to determine if this step was successful, skipped, or failed.
oc-install.conclusion
This step doesn't continue-on-error, therefore it makes little sense to check its conclusion. Here we should instead use outcome. See https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context.
continue-on-error
conclusion
outcome
Furthermore, the way this argument is currently provided to the python script makes it possible for this value to be a boolean set to False instead of a string.
False
Comes from this discussion
Currently, the step that prepares the PR comment uses the
oc-install.conclusionvalue to determine if this step was successful, skipped, or failed.This step doesn't
continue-on-error, therefore it makes little sense to check itsconclusion. Here we should instead useoutcome. See https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context.Furthermore, the way this argument is currently provided to the python script makes it possible for this value to be a boolean set to
Falseinstead of a string.