openshift-helm-charts / development

0 stars 17 forks source link

Better handle oc-install outcome #288

Closed mgoerens closed 10 months ago

mgoerens commented 10 months ago

The oc-install step doesn't continue-on-error, hence we should use .outcome instead of .conclusion to check if it runned successfully, was skipped or failed.

This information is never empty, hence there is no need to default the value of this argument to False in prepare_pr_comment.py.

Closes #287