openshift-helm-charts / development

0 stars 17 forks source link

Make the PR comment accessible to the metrics step #290

Closed komish closed 12 months ago

komish commented 12 months ago

At the moment, Metrics reporting is failing because the PR comment it needs is no longer available in the job where it runs.

https://github.com/openshift-helm-charts/charts/actions/runs/6709583883/job/18233057391#step:11:53

I believe that the metrics step can probably be extracted out into its own execution such that it doesn't cause the release step to fail, but until that gets prioritizes, this PR pulls the PR comment contents from the chart-verifier task and into the release task by encoding it in a step of the former job, and then writing it back to the expected location in a step of the latter job.

Definitely a temporary measure, but it's a quick way to get the release tasks to start passing. At the moment, I would expect them all to fail, even though all the actual releasing activity (e.g. pushing charts, public keys, indexing) succeeded.

Once this merges, I'll probably cut a release to get this into the production pipeline, even though the content is small.