search

openshift-helm-charts / development

0 stars 17 forks source link

Identify root cause of environment setup issues In workflow test #305

Open komish opened 10 months ago

komish commented 10 months ago

Recent certification triggered a workflow_test run that failed. This workflow doesn’t technically run on chart certifications, but rather programmatically auto passes. A failure is unexpected.

https://github.com/openshift-helm-charts/charts/actions/runs/7134584056/job/19429691212?pr=1133

komish commented 10 months ago

This was recently addressed in https://github.com/openshift-helm-charts/development/pull/306 but will be reverted.

The PR pull step doesn't actually need to change here. The root cause is that the a contributor submitted a PR to the production repository from an old base branch. Specifically, they submitted a PR sourced from our production repository at the 1.6.1 release. As of 1.6.2, we switched to python 3.10, which also required some changes to our dependency versions.

What happens is that our python environment within GHA (using Python 3.10) is trying to install the dependencies at the wrong versions, and that's what throws the error.

The "Workflow Test" test is really only used for version releases in our Charts/Stage/Sandbox repositories, and so it likely makes more sense for us to identify a better path to run this than on every PR (e.g. maybe we change a cookie file containing the new version and trigger on that). For now, I'm reverting the change.