Remove old version of E2E testing

komish commented 7 months ago

This PR removes the following directories:

tests/functional/step_defs
tests/functional/utils
tests/functional/features

As well as the __init__.py file that enables the module, and a reference to the module in an existing CI scripts.

From what I can tell, there are no references to these feature definitions, and they match the equivalent features that live within tests/functional/behave_features. I believe the behave_features directory was a migration destination from an original pytestbdd-driven approach. All references that I can find to the tests/ directory refer directly to the tests/functional/behave_features directory, and so I've concluded that these tests are duplicates.

Here are the locations I see that refer to the tests/functional directory. All locations reference the behave_features specifically.

at 11:12:37 ❯ grep -R tests/functional .github/workflows/
.github/workflows/nightly_test.yml:          ve1/bin/behave tests/functional/behave_features/ --tags=full --logging-level=WARNING --no-capture --no-color
.github/workflows/version_check.yml:          ve1/bin/behave tests/functional/behave_features/ --tags=version-change --logging-level=INFO --no-capture --no-color
.github/workflows/version_check.yml:          ve1/bin/behave tests/functional/behave_features/ --tags=version-change --logging-level=INFO --no-capture --no-color
.github/workflows/version_check.yml:          ve1/bin/behave tests/functional/behave_features/ --tags=version-change --logging-level=INFO --no-capture --no-color
.github/workflows/version_check.yml:          ve1/bin/behave tests/functional/behave_features/ --tags=version-change --logging-level=INFO --no-capture --no-color
.github/workflows/release.yml:          ve1/bin/behave tests/functional/behave_features/ --tags=full --logging-level=WARNING --no-capture --no-color
.github/workflows/test.yml:            ve1/bin/behave tests/functional/behave_features/ --tags=full --logging-level=WARNING --no-capture --no-color
.github/workflows/test.yml:            ve1/bin/behave tests/functional/behave_features/ --tags=smoke --logging-level=WARNING --no-capture --no-color
.github/workflows/test.yml:          ve1/bin/behave tests/functional/behave_features/ --tags=version-change --logging-level=WARNING --no-capture --no-color

Please comb through this and make sure I've not inadvertently missed some reference to these files that would motivate us to leave them in place.

mgoerens commented 7 months ago

EDIT: didn't see you also opened https://github.com/openshift-helm-charts/development/pull/313 :+1:

"Python style enforce" check fails on files that weren't touch by this PR.

komish commented 7 months ago

@mgoerens

Rebased to include the changes from now-merged #313.
Python Style is passing.
E2E Running and then this should be set to go.

openshift-helm-charts / development

Remove old version of E2E testing #312