search

openshift-helm-charts / development

0 stars 17 forks source link

Adds scripts required to support OWNERS file testing and Workflow repository management. #320

Closed komish closed 6 months ago

komish commented 6 months ago

WorkflowRepoManager provides some basic hooks into the operations we take against the local GitHub repository (e.g. adding branches, worktrees), and in some cases, the remote. This allows us to more effectively clean up after ourselves locally/remotely.

The end goal for this is to refactor the chart certification workflow to use it in the future.

OwnersFileSubmissionE2ETest is a net-new E2E testing class, supporting the testing of OWNERS file submissions from the user, and ensuring certain things take place when that's done.

The rest of the changes support these net new components.

Note that there are some changes that impact the production chart_certification script. These changes are minimally impactful to the code, and should be non-impactful to the execution of these in E2E. In an effort to avoid duplicate code paths, I had to modify a function signature that was used by both the new tests as well as the old.

komish commented 6 months ago

@mgoerens I believe I've addressed most comments. Commits left in place to align with code review. Thanks for looking!

komish commented 6 months ago

I added a few more changes from comments that were hidden from me in the GitHub UI. "Load more comments...". Thanks GitHub :sob: