Closed komish closed 5 months ago
@mgoerens I believe I've addressed everything you've requested.
Re: Newlines between steps. I've received that feedback before. I don't find it strictly necessary, but I also don't mind it at all. If I've missed them, I'm happy to add them. If it doesn't happen in this PR, I can go back and normalize all workflows at the same time that I'm standardizing on a single github runner image (e.g. the ubuntu-22.04 change).
~Do Not Merge.~
~I will remove :point_up: if and when this this is valid to merge/review. I have intentionally not applied the draft label because this prevents certain CI operations from running.~
[EDIT] This is ready for review.
This PR contains all of the impactful changes to how the certification pipeline works in order to resolve issues when depending on charts we provide.
In effect, this PR enables:
In addition, this PR includes E2E testing extensions for some of the new logic.
Change summary by file:
.github/workflows/mercury_bot.yml
scripts/src/checkprcontent/checkpr.py
org-chart
).tests/functional/behave_features/common/utils/chart_certification.py
org-chart
).tests/functional/behave_features/environment.py
.github/workflows/owners-redhat.yml (new)
.github/workflows/lock-sanity-check.yml (new)
.github/workflows/check-locks-on-owners-submission.yml (new)
tests/functional/behave_features/HC-20_owners_file.feature (new)
tests/functional/behave_features/steps/implementation_owners.py (new)